Attention is currently required from: Martin L Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80008?usp=email )
Change subject: arch/arm: Reformat C files with clang-format v16 ......................................................................
Patch Set 1:
(2 comments)
File src/arch/arm/armv7/mmu.c:
https://review.coreboot.org/c/coreboot/+/80008/comment/becb3a47_49fb176b : PS1, Line 22: How does it decide to do these comment indentations? Here it aligns to the comment in the previous line, but further up e.g. the comment after `0 << 6 | ` doesn't get aligned to the one after `1 << 10 | `. What's the rule it is using? (Not saying that it looks terrible, I'm just curious how it works.)
https://review.coreboot.org/c/coreboot/+/80008/comment/79b9a7fc_80b12cb0 : PS1, Line 93: What is this? This looks like a bug? (It actually looks like it would align the closing brace, not that we'd want that, if it also did align the equal signs... but then it doesn't do that.)