build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57755 )
Change subject: [WIP]: Cache ext BIOS window as CBFS read is pointing this range ......................................................................
Patch Set 1:
(6 comments)
File src/arch/x86/postcar_loader.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128525): https://review.coreboot.org/c/coreboot/+/57755/comment/761bf319_1d8a0c96 PS1, Line 86: if (!CONFIG(BOOT_DEVICE_MEMORY_MAPPED)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128525): https://review.coreboot.org/c/coreboot/+/57755/comment/8fa3d5e6_4174499c PS1, Line 86: if (!CONFIG(BOOT_DEVICE_MEMORY_MAPPED)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128525): https://review.coreboot.org/c/coreboot/+/57755/comment/9b095788_31d5801a PS1, Line 87: return; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128525): https://review.coreboot.org/c/coreboot/+/57755/comment/33747442_63a80c03 PS1, Line 87: return; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128525): https://review.coreboot.org/c/coreboot/+/57755/comment/c861491b_056324b0 PS1, Line 88: postcar_frame_add_mtrr(pcf, CACHE_ROM_BASE, CACHE_ROM_SIZE, type); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128525): https://review.coreboot.org/c/coreboot/+/57755/comment/d02be755_196591d5 PS1, Line 88: postcar_frame_add_mtrr(pcf, CACHE_ROM_BASE, CACHE_ROM_SIZE, type); please, no spaces at the start of a line