Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37115 )
Change subject: sb/intel/bd82x6x: Support ME Soft Temporary Disable Mode ......................................................................
Patch Set 7:
(11 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/37115/5/src/mainboard/lenovo/x230/c... File src/mainboard/lenovo/x230/cmos.default:
https://review.coreboot.org/c/coreboot/+/37115/5/src/mainboard/lenovo/x230/c... PS5, Line 17: Disable
Ooor... […]
I think I'll turn it into enum me_state with values Normal and Disabled.
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/me_8.x.c:
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 521: reset
Reset of which kind? Looks like a full reset but with extra steps
Renamed and added some comments.
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 539: 0x06, 0x01
What's this?
Added a comment.
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 555: sence
sense
Removed.
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 557: bool wait_ready = false;
No need for that wait_ready boolean
Removed.
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 560: __func__);
fits on the previous line
Removed.
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 565: pci_write_config32(dev, PCI_ME_H_GS, 0x20000000);
What does this do?
Added a comment.
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 618: __func__);
fits on the previous line
Done
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 768: mkhi_global_reset
Ah, thought your reset() function is a global reset like this one.
This global reset via mkhi doesn't even work when I try it. But what I need is CF9 + CF9GR that works perfectly.
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 796: Softwate
Software
Done
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 799: undisable
uh?
Lol.