Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46853 )
Change subject: mb/google/volteer/variants: Describe USB ports in devicetree ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46853/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/trondo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46853/3/src/mainboard/google/voltee... PS3, Line 103: device ref usb2_port2 on end
probe DB_USB USB3_ACTIVE ?
As far as I could tell this board is not implementing the fw_config field here correctly so I wasn't sure what probes to apply. Right now the trondo starlark config only has an entry for DB_USB_ABSENT while the MLB schematic clearly shows the Type-A port going to a DB connector and the DB schematic clearly showing a USB-A port.
I suppose I should not avoid the issue here and add the probe for USB3_ACTIVE while also submitting a change to the starlark config and ask the ODM to review.