Edward Hill has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34435 )
Change subject: mainboard/google/kahlee: create treeya variant
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34435/2/src/mainboard/google/kahlee...
File src/mainboard/google/kahlee/variants/treeya/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34435/2/src/mainboard/google/kahlee...
PS2, Line 149: register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_11)"
Should this change to EDGE (like change 28095)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34435
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40f3c9de87350777b02dd91d8c5b9dbe2eb9f6b5
Gerrit-Change-Number: 34435
Gerrit-PatchSet: 2
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: chris wang
Chris.Wang@amd.com
Gerrit-CC: Edward Hill
ecgh@chromium.org
Gerrit-Comment-Date: Fri, 16 Aug 2019 16:31:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment