Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32296 )
Change subject: mb/google/octopus: Add custom SAR values for Laser ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/32296/11/src/mainboard/google/octopus/varian... File src/mainboard/google/octopus/variants/phaser/mainboard.c:
https://review.coreboot.org/#/c/32296/11/src/mainboard/google/octopus/varian... PS11, Line 20: get_wifi_sar_cbfs_filename
For phaser, this will end up returning NULL which will default to wifi_sar_defaults.hex. […]
The only difference from before for phaser would be 2 additional print messages. i.e. before it would have been:
Error: Could not locate 'wifi_sar' in VPD. Error: failed from getting SAR limits!
and now it would be: Error: Could not locate 'wifi_sar' in VPD. Checking CBFS for default SAR values wifi_sar_defaults.hex has bad len in CBFS. Error: failed from getting SAR limits!
If we want to really avoid these, we can add a runtime check mb_has_sar() which can be implemented by phaser to return 0 when sku_id != 5. Justin, what do you think?