Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36101 )
Change subject: util/ifdtool: Add support for setting flash density on IFD V2 ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36101/3/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/36101/3/util/ifdtool/ifdtool.c@942 PS3, Line 942: chip2_offset = 3; This is not true for all "V1" descriptors btw. The component width change to 4 bits with 8 series.
The V1/V2 disctinction in ifdtool seems even more arbitrary than the changes Intel makes to the descriptor oO If anyone has the time: It would be a good idea to extract the IFD code from flashrom into a common library.