build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25382 )
Change subject: soc/cavium: Apply additional devicetree fixups ......................................................................
Patch Set 40:
(4 comments)
https://review.coreboot.org/#/c/25382/40/src/soc/cavium/cn81xx/soc.c File src/soc/cavium/cn81xx/soc.c:
https://review.coreboot.org/#/c/25382/40/src/soc/cavium/cn81xx/soc.c@78 PS40, Line 78: Remove 'phy-handle' if this option is not availble */ 'availble' may be misspelled - perhaps 'available'?
https://review.coreboot.org/#/c/25382/40/src/soc/cavium/cn81xx/soc.c@136 PS40, Line 136: /* Extract our MAC address info so we can assign them in the device tree */ line over 80 characters
https://review.coreboot.org/#/c/25382/40/src/soc/cavium/cn81xx/soc.c@168 PS40, Line 168: if (!strcmp(name, prop->prop.name)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25382/40/src/soc/cavium/cn81xx/soc.c@264 PS40, Line 264: BDK_BGXX_CMRX_RX_DMAC_CTL(bgx_interface, bgx_index)); line over 80 characters