Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47800 )
Change subject: soc/mediatek/mt8192: add i2c driver support
......................................................................
Patch Set 18:
(2 comments)
Please review and merge this patch.
It would be easier to create DRAM ToT and prevent conflict.
I wonder why I2C changes will conflict with DRAM ToT?
https://review.coreboot.org/c/coreboot/+/47800/18/src/soc/mediatek/mt8192/i2...
File src/soc/mediatek/mt8192/i2c.c:
https://review.coreboot.org/c/coreboot/+/47800/18/src/soc/mediatek/mt8192/i2...
PS18, Line 11: /* i2c0 setting */
[0] = {
(and so on for followings)
https://review.coreboot.org/c/coreboot/+/47800/18/src/soc/mediatek/mt8192/i2...
PS18, Line 92: {
[0] = {
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13835e00eb674a93aa5496a9870d1e601e263368
Gerrit-Change-Number: 47800
Gerrit-PatchSet: 18
Gerrit-Owner: wang qii
Qii.Wang@mediatek.com
Gerrit-Reviewer: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jg Daolongzhu
jg_daolongzhu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Dec 2020 03:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment