Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36674 )
Change subject: arch/x86: Add option to LZ4 compress postcar stage ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36674/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36674/12//COMMIT_MSG@10 PS12, Line 10: f p
https://review.coreboot.org/c/coreboot/+/36674/12//COMMIT_MSG@16 PS12, Line 16: when operating in CAR I don't follow this argument. Why would a higher stack requirement be better in CAR?
https://review.coreboot.org/c/coreboot/+/36674/12/src/cpu/x86/Kconfig File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/36674/12/src/cpu/x86/Kconfig@85 PS12, Line 85: This also needs CLFLUSH to work while in CAR. I'm really confused why we're directly linking ROMSTAGE_CACHED_CBMEM with COMPRESS_POSTCAR. They seem to be very separate notions.