Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35681 )
Change subject: cpu/x86/smm: Add support for long mode
......................................................................
Patch Set 5: Code-Review+1
Patch Set 5:
Patch Set 5:
(3 comments)
Do you want SMM to rely on a RO component (pagetable)? Wouldn't copying it in ASEG/TSEG be a better idea?
yes, as there's not enough space in ASEG, which is used by qemu.
Once implemented additional (runtime) pagetables could be installed in RAM.
Ok sounds reasonable. Might be interesting to port over Q35 to CONFIG_SMM_TSEG to have a POC of that too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35681
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8bba4af4688c723fc079ae905dac95f57ea956f8
Gerrit-Change-Number: 35681
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rudolf Marek
r.marek@assembler.cz
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Sun, 06 Oct 2019 10:41:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment