[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cnl: Enable VT-d

[John Zhao (Code Review)]

John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32432 )

Change subject: soc/intel/cnl: Enable VT-d
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/32432/3/src/soc/intel/cannonlake/acpi.c 
File src/soc/intel/cannonlake/acpi.c:

https://review.coreboot.org/#/c/32432/3/src/soc/intel/cannonlake/acpi.c@364 
PS3, Line 364: any platform initiated DMA
             : 	 * is restricted
> Yes, I know. So what does "restricted" mean in this […]

It would be referred to IOMMU. I am not aware that firmware drivers implementation comply with RMRRs.

https://review.coreboot.org/#/c/32432/4/src/soc/intel/common/Kconfig 
File src/soc/intel/common/Kconfig:

https://review.coreboot.org/#/c/32432/4/src/soc/intel/common/Kconfig@67 
PS4, Line 67: 	default n
> Thank you for moving it to Kconfig. […]

Yes, it is selected in cannonlake/Kconfig.