Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81376?usp=email )
Change subject: soc/intel/adl: Guard TWL SoC missing UPDs for build integrity ......................................................................
soc/intel/adl: Guard TWL SoC missing UPDs for build integrity
Adds config-based guards for Usb4CmMode and CnviWifiCore UPDs, specific to Twin Lake SoCs (SOC_INTEL_TWINLAKE).
Prevents compilation errors due to missing UPD definitions.
BUG=b:330654700 TEST=Able to build google/tivviks.
Change-Id: I6e0a9a7536df6295e23bf06003539e56bb98a311 Signed-off-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/alderlake/fsp_params.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/81376/1
diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index 4ddf1e4..33ebee3 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -683,7 +683,9 @@ s_cfg->UsbTcPortEn |= BIT(i); }
+#if !CONFIG(SOC_INTEL_TWINLAKE) s_cfg->Usb4CmMode = CONFIG(SOFTWARE_CONNECTION_MANAGER); +#endif }
static void fill_fsps_chipset_lockdown_params(FSP_S_CONFIG *s_cfg, @@ -831,7 +833,9 @@ const struct soc_intel_alderlake_config *config) { /* CNVi */ +#if !CONFIG(SOC_INTEL_TWINLAKE) s_cfg->CnviWifiCore = is_devfn_enabled(PCH_DEVFN_CNVI_WIFI); +#endif s_cfg->CnviMode = is_devfn_enabled(PCH_DEVFN_CNVI_WIFI); s_cfg->CnviBtCore = config->cnvi_bt_core; s_cfg->CnviBtAudioOffload = config->cnvi_bt_audio_offload;