Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31229 )
Change subject: src/mainboard/pcengines/apu2/OemCustomize.c: Enable CPB feature
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31229/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31229/2//COMMIT_MSG@13
PS2, Line 13: during huge load. Processor has additional boosted P-states when
'during high load if other cores idle'
Done. I have also changed the max frequency to 1400MHz, since memtest86+ shows overall ~40% increase in memory speed and the processor's specification says max frequency 1400MHz. The benchmark results showed ~20% increase in performance, but these are probably biased by background operations that OS performs.
https://review.coreboot.org/#/c/31229/2//COMMIT_MSG@17
PS2, Line 17: memory bandwidth.
Yet from specs we know that enabling CPB does not increase overall memory bandwidth? […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31229
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e080bfaee06fd13cedf5151d4a598ec212213f2
Gerrit-Change-Number: 31229
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 11 Feb 2019 11:23:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment