5 Oct
2019
5 Oct
'19
9 a.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35753 )
Change subject: sb/intel/ibexpeak: Implement PCH function disable in chip_ops ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35753/7/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35753/7/src/southbridge/intel/ibexp... PS7, Line 38: smm-y += smihandler.c me.c ../bd82x6x/me_8.x.c ../bd82x6x/pch.c
Fix pch.c here too? This probably triggers need for __SIMPLE_DEVICE__.
Apparently there is no need to link that file.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35753
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78d25ffe9af482c77d397a9fdb4f0127e40baddc
Gerrit-Change-Number: 35753
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 05 Oct 2019 09:00:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment