1 Dec
2022
1 Dec
'22
9:15 p.m.
Attention is currently required from: Robert Zieba, Jason Glenesk, Raul Rangel, Matt DeVillier, Angel Pons, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67936 )
Change subject: soc/amd/common/xhci: Add support for logging XHCI wake events ......................................................................
Patch Set 12: Code-Review+2
(1 comment)
File src/soc/amd/common/block/include/amdblocks/xhci.h:
https://review.coreboot.org/c/coreboot/+/67936/comment/6f250f20_14c5462c PS10, Line 13: #define XHCI_GEVENT GEVENT_31
This definition is just for clarity. […]
Seems reasonable. Is this same GEVENT used for XHCI on all chips?
--
To view, visit https://review.coreboot.org/c/coreboot/+/67936
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0489e1df55c4e63cb8a306099e3f31c82eebd58
Gerrit-Change-Number: 67936
Gerrit-PatchSet: 12
Gerrit-Owner: Robert Zieba robertzieba@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Robert Zieba robertzieba@google.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 01 Dec 2022 21:15:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Robert Zieba robertzieba@google.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment