Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23135 )
Change subject: superio: Add ASpeed AST2400
......................................................................
Patch Set 17:
(3 comments)
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/Makefile.inc
File src/superio/aspeed/Makefile.inc:
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/Makefile.inc@17
PS17, Line 17: fintek
aspeed
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/Makefile.inc@18
PS17, Line 18: romstage-$(CONFIG_SUPERIO_ASPEED_COMMON_ROMSTAGE) += common/early_serial.c
also link it in the bootblock, as with C_ENVIRONMENT_BOOTBLOCK you want serial output there too.
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/common/Kconfig
File src/superio/aspeed/common/Kconfig:
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/common/Kconfig@2...
PS17, Line 20: ROMSTAGE
PRE_RAM
--
To view, visit
https://review.coreboot.org/c/coreboot/+/23135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58fce31f0a2483e61e9d31f38ab5a059b8cf4f83
Gerrit-Change-Number: 23135
Gerrit-PatchSet: 17
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 12 Apr 2019 07:46:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment