Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32185 )
Change subject: libpayload: Enable -Wconversion
......................................................................
Patch Set 7:
include/endian.h:39:28: error: conversion from 'int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Werror=conversion]
return ((in & 0xFF) << 8) | ((in & 0xFF00) >> 8);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc37c50cae90d283bd6ec240dd7de3546485a9a9
Gerrit-Change-Number: 32185
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Fri, 22 Nov 2019 21:48:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment