Attention is currently required from: Arthur Heymans. Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38202 )
Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading ......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
This looks like a board/device specific hack
In addition to lenovo/g505s it could've benefited a similar hp/pavilion_m6_1035dx laptop which (like G505S) has AMD integrated GPU + AMD discrete GPU and both without a dedicated storage for their VBIOS ROMs. But it seems no-one is using 1035dx, so yes this hack benefits only G505S at the moment.
why not have a PCI driver for the discrete GPU on your device with a different init function. It could even load the option rom at other available addresses, to not conflict with the VGA option ROM loading.
I hope you mean a coreboot's PCI driver? If yes, I need to search for a good example and figure out how to do this - with keeping you helpful comments below in mind, of course