Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37645 )
Change subject: mb/google/hatch: Add mushu variant
......................................................................
Patch Set 6: Code-Review+1
(6 comments)
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/mushu/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/...
PS4, Line 11: [PchSerialIoIndexSPI1] = PchSerialIoPci,
Switched to mirror Hatch reference laptop.
Ack
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/...
PS4, Line 26: RFU
Switched to mirror Hatch reference laptop.
Ack
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/...
PS4, Line 27: PS175
Switched to mirror Hatch reference laptop.
Ack
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/...
PS4, Line 28: MST
Switched to mirror Hatch reference laptop.
Ack
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/...
PS4, Line 36: i2c[0]
Switched to mirror Hatch reference laptop.
Ack
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/...
PS4, Line 41: .i2c[1]
Switched to mirror Hatch reference laptop.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37645
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81b5bf960ead0463159ac35f4f96e3ccc8c0364e
Gerrit-Change-Number: 37645
Gerrit-PatchSet: 6
Gerrit-Owner: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philip Chen
philipchen@chromium.org
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matthew Blecker
matthewb@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Dec 2019 19:03:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Bob Moragues
moragues@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment