Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45704 )
Change subject: sc7180: Remove LIMITS_CFG loading in romstage. ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45704/3/src/soc/qualcomm/sc7180/mem... File src/soc/qualcomm/sc7180/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/45704/3/src/soc/qualcomm/sc7180/mem... PS3, Line 46: REGION(qclib, 0x1486a000, 600K, 4K) The QcLib load address is hardcoded in the QcLib binary. Adding more space here is not useful, it will not be used (unless we want to uprev QcLib for this which seems a bit excessive for 4K). Just leave it empty or add it to the PMIC part or something.