Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45873 )
Change subject: mb, soc: change mainboard_get_dram_part_num() prototype ......................................................................
Patch Set 6:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45873/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45873/3//COMMIT_MSG@7 PS3, Line 7: lib
You haven't really added this to lib in this CL. So, just […]
Done
https://review.coreboot.org/c/coreboot/+/45873/3/src/soc/intel/alderlake/rom... File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/45873/3/src/soc/intel/alderlake/rom... PS3, Line 44: = 0
Ack.
Done
https://review.coreboot.org/c/coreboot/+/45873/3/src/soc/intel/elkhartlake/r... File src/soc/intel/elkhartlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/45873/3/src/soc/intel/elkhartlake/r... PS3, Line 45: = 0
Please see comment on alderlake.
Done
https://review.coreboot.org/c/coreboot/+/45873/3/src/soc/intel/elkhartlake/r... PS3, Line 46: part_name_overridden
I disagree, please see explanation on alderlake.
Done
https://review.coreboot.org/c/coreboot/+/45873/3/src/soc/intel/jasperlake/ro... File src/soc/intel/jasperlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/45873/3/src/soc/intel/jasperlake/ro... PS3, Line 45: = 0
please see my alderlake response
Done
https://review.coreboot.org/c/coreboot/+/45873/3/src/soc/intel/tigerlake/rom... File src/soc/intel/tigerlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/45873/3/src/soc/intel/tigerlake/rom... PS3, Line 45: = 0;
please see my alderlake response
Done