Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28464 )
Change subject: drivers/intel/fsp1_1: Configure UART after memory init
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/28464/3/src/drivers/intel/fsp1_1/raminit.c
File src/drivers/intel/fsp1_1/raminit.c:
https://review.coreboot.org/#/c/28464/3/src/drivers/intel/fsp1_1/raminit.c@1...
PS3, Line 128: mainboard_after_memory_init
so you call the function and add a weak stub below. […]
This function is used with update of Facebook FBG-1701 ( https://review.coreboot.org/c/coreboot/+/30414)
Note: At the moment I created this patch, I was not aware that you can rebase a patch. The 30414 patch requires the function prototype of this patch. To have the 30414 patch build, I removed the call of mainboard_after_memory_init().
My plan is to wait till this patch in merged before updating the other patch.
Does this make sense?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28464
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb6c9e4153b3de58791b211c7f4241be3bceae9d
Gerrit-Change-Number: 28464
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 11 Apr 2019 11:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment