22 Oct
2019
22 Oct
'19
3:04 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35596 )
Change subject: mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35596/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35596/2/src/mainboard/google/hatch/... PS2, Line 61: register "PchPmSlpS0Vm075VSupport" = "1"
I checked the code, it only needs to enable PchPmSlpS0Vm075VSupport, then FSP will help to config th […]
Furquan, given your +2 I'll assume that you're satisfied with that answer ;-)
--
To view, visit https://review.coreboot.org/c/coreboot/+/35596
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia02ff8823883489b36349457213409496f082f36
Gerrit-Change-Number: 35596
Gerrit-PatchSet: 4
Gerrit-Owner: Kane Chen kane.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kane Chen kane.chen@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 22 Oct 2019 13:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kane Chen kane.chen@intel.com
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment