Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36221 )
Change subject: WIP: Add configurable ramstage support for minimal PCI scanning
......................................................................
Patch Set 14:
Patch Set 14:
Patch Set 14:
That is the approach I would want vendor to really put the effort into. But it turns out to be more work than I plan to volunteer for at least. For the review of this commit I am mostly in "damage management mode" to overlook that an unnecessary complex bandage does not land.
Kyosti, how does the damage look at present. I'm working on one more approach to try to bring in Nico's idea but not done yet.
It's much less intrusive than before :). Specially if we take into account that there would be few cases where you need to explicitly opt-out.
However, looking at some logged times created from CB:36574 and CB:36584, I am a bit concerned that majority of advertised performance boost of partial enumeration / allocation would be due to console. Still waiting for Intel to provide us with some data.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2073d9f8e9297c2b02530821ebb634ea2a5c758e
Gerrit-Change-Number: 36221
Gerrit-PatchSet: 14
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 02 Nov 2019 21:02:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment