Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46057 )
Change subject: soc/intel/xeon_sp: Use generic config_t
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46057/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46057/1//COMMIT_MSG@9
PS1, Line 9: Don't use the silicon specific typedef to get common config options.
Technically, the only typedef here is config_t, which is not a pointer: […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If80b678037b4d79387e0a0f722c540df4aae2416
Gerrit-Change-Number: 46057
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Tue, 06 Oct 2020 17:44:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment