Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36914 )
Change subject: binaryPI: implement C bootblock ......................................................................
Patch Set 24:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36914/20/src/drivers/amd/agesa/boot... File src/drivers/amd/agesa/bootblock.c:
https://review.coreboot.org/c/coreboot/+/36914/20/src/drivers/amd/agesa/boot... PS20, Line 17: #include <northbridge/amd/agesa/agesa_helper.h>
This could be a static function here. […]
Done
https://review.coreboot.org/c/coreboot/+/36914/20/src/northbridge/amd/agesa/... File src/northbridge/amd/agesa/agesa_helper.h:
https://review.coreboot.org/c/coreboot/+/36914/20/src/northbridge/amd/agesa/... PS20, Line 66:
Not anymore after your patches?
Done
https://review.coreboot.org/c/coreboot/+/36914/20/src/northbridge/amd/pi/nb_... File src/northbridge/amd/pi/nb_util.c:
https://review.coreboot.org/c/coreboot/+/36914/20/src/northbridge/amd/pi/nb_... PS20, Line 19: void *get_ap_entry_ptr(void)
Right, put these in biosram. […]
Done in CB:37416