Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35439 )
Change subject: sb/intel/ibexpeak: Add CIR initialization ......................................................................
Patch Set 8:
(8 comments)
https://review.coreboot.org/c/coreboot/+/35439/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35439/4//COMMIT_MSG@9 PS4, Line 9: This properly the chipset initialization registers.
Missing verb: sets?
Done
https://review.coreboot.org/c/coreboot/+/35439/4//COMMIT_MSG@15 PS4, Line 15: from S3.
Can you please summarize what changed, or what the benefits are?
Done
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/early_cir.c:
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... PS1, Line 21: set
sets
Done
https://review.coreboot.org/c/coreboot/+/35439/4/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/early_cir.c:
https://review.coreboot.org/c/coreboot/+/35439/4/src/southbridge/intel/ibexp... PS4, Line 21: set
sets
Done
https://review.coreboot.org/c/coreboot/+/35439/4/src/southbridge/intel/ibexp... PS4, Line 25: registers
Registers? Also add (CIR) to the line?
Done
https://review.coreboot.org/c/coreboot/+/35439/4/src/southbridge/intel/ibexp... PS4, Line 56: if (chipset_type == NEHALEM_DESKTOP)
Add a comment with a datasheet section reference?
Done
https://review.coreboot.org/c/coreboot/+/35439/4/src/southbridge/intel/ibexp... PS4, Line 85: die("unsupported CPU!\n");
Print out the model?
Done
https://review.coreboot.org/c/coreboot/+/35439/4/src/southbridge/intel/ibexp... PS4, Line 90: */
Please use one of the recommended comment styles.
Done