8 comments:
Patch Set #4, Line 9: This properly the chipset initialization registers.
Missing verb: sets?
Done
Patch Set #4, Line 15: from S3.
Can you please summarize what changed, or what the benefits are?
Done
File src/southbridge/intel/ibexpeak/early_cir.c:
sets
Done
File src/southbridge/intel/ibexpeak/early_cir.c:
sets
Done
Patch Set #4, Line 25: registers
Registers? Also add (CIR) to the line?
Done
Patch Set #4, Line 56: if (chipset_type == NEHALEM_DESKTOP)
Add a comment with a datasheet section reference?
Done
Patch Set #4, Line 85: die("unsupported CPU!\n");
Print out the model?
Done
Please use one of the recommended comment styles.
Done
To view, visit change 35439. To unsubscribe, or for help writing mail filters, visit settings.