Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33652 )
Change subject: arch/x86/acpi: Add os.asl ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl File src/arch/x86/acpi/os.asl:
https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl@84 PS1, Line 84: Zero
if I'm not wrong, "Zero" is also ok
Yes, Zero and One are the same as 0x00 and 0x01, but the latter are more consistent with the rest of the values. I seem to have some sort of OCD with consistency.
https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl@94 PS1, Line 94: If(SCPM(local0, "Linux"))
So how do I identify Linux? From the documentation you provided, Linux answers ""Microsoft Windows N […]
Right. AFAIUI, the problem with _OSI(Linux) is that linux does not maintain an interface, so probing just for "linux" can match anything, even custom kernels. So, as to how to identify linux, I would say the answer is to not do so. If you still need to treat Linux differently, there's probably a bug in Linux which should be patched.
Oh, even ACPICA has a section about that: Section 8.1.7.2 of https://acpica.org/sites/acpica/files/acpica-reference_18.pdf