Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )
Change subject: device/Kconfig: Add HAVE_EXT_GFX kconfig ......................................................................
Patch Set 8:
Patch Set 8:
(1 comment)
I guess the main issue is that you are mixing two unrelated graphic options here.
- Preferred GPU in a (multi) GPU system
- Preferred graphic initialisation method
To resolve that I propose a new Kconfig choice "Preferred GPU configuration" instead of a single Kconfig:
- Disable all GPUs
- Enable IGD only in multi GPU setup
- Enable PEG only in multi GPU setup (default)
- Enable all GPUs in multi GPU setup
Yes, you can crate such config and align existing CB code.
It does not depend on graphic initialisation, but graphic initialisation would depend on it. For example you would never run GOP / libgfxinit in case of "Enable PEG only in multi GPU setup".
FSP would make use of the new choice to properly configure all graphic devices.
For external GFX card over PCIE initialization FSP doesn't come to picture, we just need some way to tell to not initialize on board GFX as priority is with GFX over PCIE