EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48115 )
Change subject: mb/google/brya: Add EC smihandler
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s...
File src/mainboard/google/brya/smihandler.c:
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s...
PS3, Line 10: void mainboard_smi_gpi_handler(const struct gpi_status *sts)
: {
: /* TODO: Process SMI events from GPI */
: }
Done
We can add it back if needed. dedede keep this but volteer remove it, so.. I like to remove it for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I211f5755ff44514ab7ab4083f684ddd88c23fe48
Gerrit-Change-Number: 48115
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 04:36:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment