[coreboot-gerrit] Change in coreboot[master]: security/lockdown: Write-protect WP_RO

[Patrick Rudolph (Code Review)]

Hello Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi, Frans Hendriks, Christian Walter, Julius Werner, Aaron Durbin, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32705

to look at the new patch set (#14).

Change subject: security/lockdown: Write-protect WP_RO
......................................................................

security/lockdown: Write-protect WP_RO

Allow to write protect only the WP_RO region in case of enabled VBOOT.
One can either lock the boot device in VERSTAGE early if VBOOT is enabled,
or late in RAMSTAGE. Both options have their downsides as explained below.

Lock early if you don't trust the code that's stored in the writeable
flash partition. This prevents write-protecting the MRC cache, which
is written in ramstage. In case the contents of the MRC cache are
corrupted this can lead to system instability or trigger unwanted code
flows inside the firmware.

Lock late if you trust the code that's stored in the writeable
flash partition. This allows write-protecting the MRC cache, but
if a vulnerability is found in the code of the writeable partition
an attacker might be able to overwrite the whole flash as it hasn't
been locked yet.

Change-Id: I72c3e1a0720514b9b85b0433944ab5fb7109b2a2
Signed-off-by: Patrick Rudolph 
Signed-off-by: Christian Walter 
---
M src/include/boot_device.h
M src/security/lockdown/Kconfig
M src/security/lockdown/Makefile.inc
M src/security/lockdown/lockdown.c
M src/security/vboot/vboot_logic.c
5 files changed, 52 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/32705/14