HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37415 )
Change subject: src: (part 1) Add missing 'include <commonlib/helpers.h>'
......................................................................
Patch Set 4: Code-Review-1
Patch Set 4: Code-Review-1
Isn't <commonlib/helpers.h> chain-included via <types.h>? I think that should be enough. We shouldn't need to encode every detail of where common utility stuff comes from (which changes on occasion) in every file.
it is included via <stddef.h>.
the idea is to set <stddef.h> providing only standards.
maybe it is a bad idea, at least, it needs a lot of work and time for review.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37415
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ca717f4b980020e80ac39ea46b430b72848963d
Gerrit-Change-Number: 37415
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 03 Dec 2019 11:03:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment