26 Nov
2019
26 Nov
'19
5:41 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36517 )
Change subject: sc7180: Add SPI QUP driver ......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36517/7/src/soc/qualcomm/sc7180/qco... File src/soc/qualcomm/sc7180/qcom_qup_se.c:
https://review.coreboot.org/c/coreboot/+/36517/7/src/soc/qualcomm/sc7180/qco... PS7, Line 95: write32(®s->geni_m_irq_clear, m_irq); Can we merge all the changes to this file from this patch back into the first QUP patch (CB:35499) please? No point in committing older code there and then changing it all up again here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36517
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86f4fcff6f9537373f70a43711130d7f28bd5e09
Gerrit-Change-Number: 36517
Gerrit-PatchSet: 7
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Akash Asthana akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Roja Rani Yarubandi c_rojay@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Wed, 27 Nov 2019 01:41:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment