build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41692 )
Change subject: mb/google/poppy/variants: Create Sylas variant
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41692/1/src/mainboard/google/poppy/...
File src/mainboard/google/poppy/variants/sylas/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41692/1/src/mainboard/google/poppy/...
PS1, Line 220: break;
break is not useful after a goto or return
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41692
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b1a0f1e9fe6b20cc01bc4cc6718c44ccf5b0789
Gerrit-Change-Number: 41692
Gerrit-PatchSet: 1
Gerrit-Owner: Ginger Cheng
cheng.ginger@inventec.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 25 May 2020 10:23:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment