21 Jul
2020
21 Jul
'20
7:38 a.m.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43665 )
Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:
https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... PS1, Line 13: PAD_SCI
SCI is unnecessary […]
Dear Furquan, yes active low is correct, because these is a external pull-up resistor about 2.2k, thanks a lot.
--
To view, visit https://review.coreboot.org/c/coreboot/+/43665
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e1a864bc156b434c39e8027fedf3a435757c1a7
Gerrit-Change-Number: 43665
Gerrit-PatchSet: 2
Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 Jul 2020 05:38:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-MessageType: comment