Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31108 )
Change subject: sb/intel/common/firmware: Don't call GbE binary `firmware`
......................................................................
Patch Set 1:
if you know someone at intel who can get those things clarification
I don't. The people most experienced with Intel hardware and firmware
that I know are not working at Intel. The scores on this change pretty
much reflect that.
i have no problem, you can get right comment and clarification and
share here. Else i can volunteer here to get required details on this.
please give me few working days
Please do so. With your -2, it is your obligation to give "concrete
recommendations for what could be changed[...]". Also, if somebody at
Intel tells you that it is firmware, please be prepared to justify
that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31108
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife6190639e7f05da2cb6eddeb1b0db0e8ffc8e6e
Gerrit-Change-Number: 31108
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-Comment-Date: Sat, 26 Jan 2019 15:15:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment