Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36604 )
Change subject: Kconfig: Have GDB_STUB depend on DRIVERS_UART
......................................................................
Patch Set 1: Code-Review+1
Patch Set 1:
Patch Set 1:
include/console/uart.h __CONSOLE_SERIAL_ENABLE__ has to be adjusted too to make it actually work.
Is that so? The GDB stub has it's own callbacks for that it seems?
__gdb_hw_init
__gdb_tx_byte
...
Ah.. I was fooled by the underscores.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbf9a1ac0e617939cafa3d66774bbd467dc01cbc
Gerrit-Change-Number: 36604
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Nov 2019 11:49:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment