[coreboot-gerrit] Change in coreboot[master]: Add configurable ramstage support for minimal PCI scanning

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36221 )

Change subject: Add configurable ramstage support for minimal PCI scanning
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36221/4/src/device/pci_device.c 
File src/device/pci_device.c:

https://review.coreboot.org/c/coreboot/+/36221/4/src/device/pci_device.c@119... 
PS4, Line 1195: 			dev = dev_find_slot(0, devfn);
Sigh.. dev_find_slot() should be banned. Would following work for you:

dev = pcidev_path_behind(bus, devfn);

Out of scope, but I don't like how the for-loop hardcodes dev.fn. Aaron might have some related work on that.

https://review.coreboot.org/c/coreboot/+/36221/4/src/device/pci_device.c@119... 
PS4, Line 1197: 				printk(BIOS_WARNING, "%#x is NOT static, skipping it\n", devfn);
We prefer B:D.f notation for PCI devices on console output.