Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30821 )
Change subject: mb/*/devicetree.cb: Remove unavailable PCIe ports
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Looks good, except for one thing.
https://review.coreboot.org/#/c/30821/3/src/mainboard/asus/p5qpl-am/devicetr...
File src/mainboard/asus/p5qpl-am/devicetree.cb:
https://review.coreboot.org/#/c/30821/3/src/mainboard/asus/p5qpl-am/devicetr...
PS3, Line 57: device pci 1d.0 on end # USB
: device pci 1d.1 on end # USB
: device pci 1d.2 on end # USB
: device pci 1d.3 on end # USB
: device pci 1d.7 on end # USB
: device pci 1e.0 on end # PCI bridge
Um?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30821
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I154cae358fb7f862fc0c8eaa620474b37b5e6484
Gerrit-Change-Number: 30821
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Apr 2019 18:33:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
