Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32332 )
Change subject: mb/google/octopus: Add wifi_default_sar.hex for other sku DUT ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32332/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/phaser/mainboard.c:
https://review.coreboot.org/#/c/32332/1/src/mainboard/google/octopus/variant... PS1, Line 31: wifi_default_sar.hex
I thought other SKUs did not have a SAR table?
Yes, But if no this empty file, only enable WIFI_SAR_CBFS compile code base no work. 1. I mean we must enable WIFI_SAR_CBFS and point to CONFIG_WIFI_SAR_CBFS_FILEPATH, compile is ok 2. if we just use "wifi_sar-laser.hex", and CONFIG_WIFI_SAR_CBFS_FILEPATH point to this file, it will apply to wifi_sar_defaults.hex-file. like :(code directory: src/drivers/intel/wifi/Makefile.inc)
ramstage-$(CONFIG_DRIVERS_INTEL_WIFI) += wifi.c
cbfs-files-$(CONFIG_WIFI_SAR_CBFS) += wifi_sar_defaults.hex wifi_sar_defaults.hex-file := $(call strip_quotes,$(CONFIG_WIFI_SAR_CBFS_FILEPATH)) wifi_sar_defaults.hex-type := raw