Attention is currently required from: Tim Wawrzynczak.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52185 )
Change subject: mb/google/brya: Add FPMCU power control
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52185/comment/83048251_cb529119
PS1, Line 196: register "has_power_resource" = "1"
This won't work right now, b/c this will generate a power resource which will let the kernel put the […]
If we just need D0, _INI is good to use. But I am think either EC control this or we can use HW to do this since it only need 3ms delay. Totally can do it by add the CAP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a8fae80c3cc186e0a097ab2007abb656f382cbd
Gerrit-Change-Number: 52185
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 08 Apr 2021 18:07:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment