Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40024 )
Change subject: google/chromeec: Add USB MUX Interrupt ......................................................................
Patch Set 3:
Patch Set 2:
Patch Set 2:
Re on EC events: As defined in SAS EC_HOST_EVENT_USB_MUX (SCI event) is triggered from EC when there is a change needed in USB MUX.
Thanks Vijay. Could you kindly point me to the SAS document link, and relevant section.
I'm curious, if the change in the EC was made a while ago, why wasn't this change in upstream coreboot already?
At a high level, the kernel and coreboot hack to allow these events to be delivered via the LPCS notify event (crrev.com/c/2002185) cannot be upstreamed, so we have to develop a way to route this through the PD notifier mechanism.
That is a good question it was on the private branch that was used to test Volteer until this last week and upon doing TCSS testing found it missing on upstream. It appears all other parts of the patch that added this were upstreamed so it is possible that this piece was just missed cause everything else way there