Attention is currently required from: Nico Huber, Thomas Heijligen, Julius Werner.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70115 )
Change subject: libpayload/string: add strndup() function
......................................................................
Patch Set 2:
(1 comment)
File payloads/libpayload/libc/string.c:
https://review.coreboot.org/c/coreboot/+/70115/comment/f4ec1fe6_9e4c11e3
PS2, Line 333: size_t n = strlen(s);
Doesn't this defeat the point of strndup() (which is to not risk overrunning the buffer if the input […]
Perhaps Thomas wanted to use `strnlen()` as it's done in glibc (https://codebrowser.dev/glibc/glibc/string/strndup.c.html)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie509e49f21fb537692704ac6527efa09649164e3
Gerrit-Change-Number: 70115
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 04 Jan 2023 16:48:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment