Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44918 )
Change subject: drivers/intel/usb4: Add driver for USB4 retimer device ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44918/1/src/drivers/intel/usb4/reti... File src/drivers/intel/usb4/retimer/Kconfig:
https://review.coreboot.org/c/coreboot/+/44918/1/src/drivers/intel/usb4/reti... PS1, Line 1: RETIMER
Good read, thank you! The help text could be something like this, if the second sentence is accurate […]
+1
https://review.coreboot.org/c/coreboot/+/44918/1/src/drivers/intel/usb4/reti... File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/44918/1/src/drivers/intel/usb4/reti... PS1, Line 82: /* : * If (Local0 == 0) { : * // Turn power off : * _SB.PCI0.CTXS (power_gpio) : * } : */ : acpigen_write_if_lequal_op_int(LOCAL0_OP, 0); : acpigen_disable_tx_gpio(power_gpio); : acpigen_pop_len(); : : /* : * If (Local0 == 1) { : * // Turn power on : * _SB.PCI0.STXS (power_gpio) : * } : */ : acpigen_write_if_lequal_op_int(LOCAL0_OP, 1); : acpigen_enable_tx_gpio(power_gpio); : acpigen_pop_len();
Don't we have a way to write an `Else` in acpigen? Or is it necessary to only handle 0 and 1?
yes, there's acpigen_write_else(), but the result (Local0) is coming from the GTXS Method, which reads a GPIO and returns 0 or 1 (https://doc.coreboot.org/acpi/gpio.html)