[coreboot-gerrit] [S] Change in coreboot[master]: x86: pci_io_cfg: Make constant unsigned to fix out of bounds shift

[Paul Menzel (Code Review)]

Attention is currently required from: Nico Huber, Angel Pons.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51292 )

Change subject: x86: pci_io_cfg: Make constant unsigned to fix out of bounds shift
......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/51292/comment/a4a533b2_c6d9629b 
PS1, Line 9: building
> Just noticed this. The error does not happen when *building* coreboot. […]

Yes, it’s ambiguous. It’s happening when running an image *built* with that config option. I can make it unambiguous.

File src/arch/x86/include/arch/pci_io_cfg.h:

https://review.coreboot.org/c/coreboot/+/51292/comment/1db837ae_03291170 
PS1, Line 13: 1UL
> Uhm, no? […]

Done