Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31968 )
Change subject: mediatek/mt8183: Fix RTC initialization flow ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31968/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31968/1//COMMIT_MSG@9 PS1, Line 9: 1. fix RTC initialization flow : 2. fix RTC lpd settings If there's a specific issue describing details (the 80501386 below is for tracking all firmware changes), we should document here what we are solving(what you see without this patch), how it needs to be fixed, and how it is verified.
https://review.coreboot.org/#/c/31968/1/src/soc/mediatek/common/rtc.c File src/soc/mediatek/common/rtc.c:
https://review.coreboot.org/#/c/31968/1/src/soc/mediatek/common/rtc.c@150 PS1, Line 150: printk(BIOS_INFO, "[RTC] con = %x, pwrkey1 = %x, pwrkey2 = %x\n", : con, pwrky1, pwrky2); Is this for your local debugging, or it is really helpful to always print this?