Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45115 )
Change subject: soc/amd/picasso: Assign IOAPIC IDs, GNB APIC base with FSP ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45115/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45115/3//COMMIT_MSG@14 PS3, Line 14: consumed by the GNB IOAPIC.
Why should that be configurable, and can be figured out in code (greater than MAX_CPUS and unique)?
Ack. That's kind of the point I was making in this comment. https://review.coreboot.org/c/coreboot/+/45115/1/src/soc/amd/picasso/Kconfig.... All we want is to ensure consistent values are used everywhere. We have some other improvements in mind, so perhaps that can be a follow-on.
https://review.coreboot.org/c/coreboot/+/45115/3/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/45115/3/src/soc/amd/picasso/Kconfig... PS3, Line 253: the GNB's IOAPIC_ID
Please add a dot/period at the end of sentences.
Done
https://review.coreboot.org/c/coreboot/+/45115/3/src/soc/amd/picasso/Kconfig... PS3, Line 262: the FCH's IOAPIC_ID
Please add a dot/period at the end of sentences.
Done