3 comments:
Patch Set #3, Line 14: consumed by the GNB IOAPIC.
Why should that be configurable, and can be figured out in code (greater than MAX_CPUS and unique)?
Ack. That's kind of the point I was making in this comment. https://review.coreboot.org/c/coreboot/+/45115/1/src/soc/amd/picasso/Kconfig#246. All we want is to ensure consistent values are used everywhere. We have some other improvements in mind, so perhaps that can be a follow-on.
File src/soc/amd/picasso/Kconfig:
Patch Set #3, Line 253: the GNB's IOAPIC_ID
Please add a dot/period at the end of sentences.
Done
Patch Set #3, Line 262: the FCH's IOAPIC_ID
Please add a dot/period at the end of sentences.
Done
To view, visit change 45115. To unsubscribe, or for help writing mail filters, visit settings.